Skip to content

Update sentry-sdk requirement from <2.0,>=1.0.0 to >=1.0.0,<3.0 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update sentry-sdk requirement from <2.0,>=1.0.0 to >=1.0.0,<3.0 #173

wants to merge 1 commit into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 1, 2024 •
edited
Loading

Updates the requirements on sentry-sdk to permit the latest version.

Release notes

Sourced from sentry-sdk's releases.

2.0.1

Various fixes & improvements

Changelog

Sourced from sentry-sdk's changelog.

2.0.1

Various fixes & improvements

2.0.0

This is the first major update in a long time!

We dropped support for some ancient languages and frameworks (Yes, Python 2.7 is no longer supported). Additionally we refactored a big part of the foundation of the SDK (how data inside the SDK is handled).

We hope you like it!

For a shorter version of what you need to do, to upgrade to Sentry SDK 2.0 see: https://docs.sentry.io/platforms/python/migration/1.x-to-2.x

New Features

  • Additional integrations will now be activated automatically if the SDK detects the respective package is installed: Ariadne, ARQ, asyncpg, Chalice, clickhouse-driver, GQL, Graphene, huey, Loguru, PyMongo, Quart, Starlite, Strawberry.
  • Added new API for custom instrumentation: new_scope, isolation_scope. See the Deprecated section to see how they map to the existing APIs.

Changed

(These changes are all backwards-incompatible. Breaking Change (if you are just skimming for that phrase))

  • The Pyramid integration will not capture errors that might happen in authenticated_userid() in a custom AuthenticationPolicy class.
  • The method need_code_loation of the MetricsAggregator was renamed to need_code_location.
  • The BackgroundWorker thread used to process events was renamed from raven-sentry.BackgroundWorker to sentry-sdk.BackgroundWorker.
  • The reraise function was moved from sentry_sdk._compat to sentry_sdk.utils.
  • The _ScopeManager was moved from sentry_sdk.hub to sentry_sdk.scope.
  • Moved the contents of tracing_utils_py3.py to tracing_utils.py. The start_child_span_decorator is now in sentry_sdk.tracing_utils.
  • The actual implementation of get_current_span was moved to sentry_sdk.tracing_utils. sentry_sdk.get_current_span is still accessible as part of the top-level API.
  • sentry_sdk.tracing_utils.add_query_source(): Removed the hub parameter. It is not necessary anymore.
  • sentry_sdk.tracing_utils.record_sql_queries(): Removed the hub parameter. It is not necessary anymore.
  • sentry_sdk.tracing_utils.get_current_span() does now take a scope instead of a hub as parameter.
  • sentry_sdk.tracing_utils.should_propagate_trace() now takes a Client instead of a Hub as first parameter.
  • sentry_sdk.utils.is_sentry_url() now takes a Client instead of a Hub as first parameter.
  • sentry_sdk.utils._get_contextvars does not return a tuple with three values, but a tuple with two values. The copy_context was removed.
  • If you create a transaction manually and later mutate the transaction in a configure_scope block this does not work anymore. Here is a recipe on how to change your code to make it work: Your existing implementation: 
    

    • 






... (truncated)





Commits

    

  • 882ed7f Updated changelog
    • 

  • ce89048 release: 2.0.1
    • 

  • 162773c fix(integrations): Do not use convenience decorator (#3022)
    • 

  • a626f01 Add Lambda function that deletes test Lambda functions (#2960)
    • 

  • f5db9ce Refactoring propagation context (#2970)
    • 

  • d91a510 Use pid for test database name in Django tests (#2998)
    • 

  • 534a301 test(tracing): Add tests for discarded transaction debug messages
    • 

  • 5aa7c9b fix(tracing): Correct discarded transaction debug message
    • 

  • bda9deb docs(tracing): Delete inaccurate comment
    • 

  • 6a73368 build(deps): bump checkouts/data-schemas from 1e17eb5 to 4aa14a7 (#2997)
    • 

  • Additional commits viewable in compare view
    • 







Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.





Dependabot commands and options



You can trigger Dependabot actions by commenting on this PR:


    

  • @dependabot rebase will rebase this PR
    • 

  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
    • 

  • @dependabot merge will merge this PR after your CI passes on it
    • 

  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
    • 

  • @dependabot cancel merge will cancel a previously requested merge and block automerging
    • 

  • @dependabot reopen will reopen this PR if it is closed
    • 

  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    • 

  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
    • 

  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    • 

  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    • 

  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    • 




    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



          

        
      




  




      

       
            



      

  
            

    

      
    

    


      


          @dependabot
dependabot
bot



          added
  the 

  dependencies

  Pull requests that update a dependency file
 label


      May 1, 2024

    

  








      

  
      



  

  @Mr0grog






  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      
          
      

      
            Mr0grog
  

      

      

      commented


        May 1, 2024


      
    


  





      


        



  
    

      
          
@dependabot rebase


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @dependabot
  




      

        
          Update sentry-sdk requirement from <2.0,>=1.0.0 to >=1.0.0,<3.0
        

          
                        
      


      

        

    
    
    

  

    


      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          5b6f399
        
      

    

  

    

      
Updates the requirements on [sentry-sdk](https://github.com/getsentry/sentry-python) to permit the latest version.
- [Release notes](https://github.com/getsentry/sentry-python/releases)
- [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-python@v1.0...2.0.1)

---
updated-dependencies:
- dependency-name: sentry-sdk
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

    







  








      

  
          

  
  

  
      @dependabot
  dependabot
bot

        force-pushed
    the
        
      
  dependabot/pip/sentry-sdk-gte-1.0.0-and-lt-3.0


    
 branch
    from
    4ee311e    to
    5b6f399      
    Compare
  



    May 1, 2024 22:53    
    









      

  
      



  

  @Mr0grog






  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

      
          
      

      
            Mr0grog
  

      

      

      commented


        May 1, 2024


      
    


  





      


        



  
    

      
          
Putting this on ice for now, but once I get around to solving some other actual-release-related issues (e.g. #145, #165) this is worth coming back to.


From the release notes and migration guide, it looks like there are some changes that need some deeper examination and testing. We probably also want to just upgrade to sentry-sdk >=2.0.0,<3.0. I think that’s ok since this only applies to the server, which is generally meant to run as a standalone app, rather than be used as a library.


    

  • 

    Scopes now fork instead of stack. push_scope() (which we use) is deprecated, and I’m worried some behaviors we do will no longer work correctly: inside the with block, we set some things directly on the new scope, and some through the top-level SDK methods (actually I’m surprised this currently works, and don’t recall how we got to this state of affairs, even though it is probably my doing; it seems weird).
    

    • 

  • 

    The Tornado integration requires Python 3.8+ and we currently support v3.7. (We don’t configure Sentry in CI, so we may not be seeing problems we would in production, or things are breaking silently.)
    

    • 

  • 

    I believe the Internet Archive uses this server in conjunction with self-hosted Sentry, and v2 of the SDK is only compatible with Sentry server v20.6.0+. We need to check with them about changes here. (https://docs.sentry.io/platforms/python/migration/1.x-to-2.x#self-hosted)
    

    • 



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  
  

  
      @Mr0grog
  Mr0grog


        marked this pull request as draft

    May 1, 2024 23:59    
    









      

  
      



  

  @dependabot


    @github




  



    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

      
          
      

      
            dependabot
  bot

      

      

      commented

        on behalf of github

        Jul 1, 2024


      
    


  





      


        



  
    

      
          
Superseded by #177.


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            

    

      
    

    


      


          @dependabot
dependabot
bot



            closed this


      Jul 1, 2024

    

  


    


  

  
  

  
      @dependabot
  dependabot
bot

    
    deleted the
    
      
        dependabot/pip/sentry-sdk-gte-1.0.0-and-lt-3.0
    
    branch

    July 1, 2024 10:13    
    




  

  

    
  


  

      


    @Mr0grog
Mr0grog



    mentioned this pull request
    
      Jul 1, 2024
    





  


  

      
     Closed

  







  




  

  

    
  


  

      


    @Mr0grog
Mr0grog



    mentioned this pull request
    
      Aug 1, 2024
    





  


  

      
     Draft

  







  













  
  

    

      

  




      


    


    

      

        
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          



      

  

    
    

    

  

    Reviewers
  


    

    No reviews






    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    dependencies

  Pull requests that update a dependency file








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @Mr0grog